add tinkerbell-insecure-tls param to control InsecureSkipVerify #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Small justification here: when using an Ingress in front of tink (eg: ingress-nginx), having TLS enabled is essential, as non-TLS gRPC is generally not supported by Ingresses (as it would require disabling http/1.1 support in favor of http/2 on port 80). But enabling TLS before this implied the full TLS verification as well (CA/certs/CN+SAN matching etc). This allows to have TLS enabled, but with InsecureSkipVerify. It defaults to false so no unexpected changes should be introduced. |
rpardini
force-pushed
the
add-tls-insecure
branch
from
9306325 to
e803be8
Compare
Member
Author
|
updated after making CI pass (gofumpt, gosec, etc) |
Member
Author
|
Reference kubernetes/ingress-nginx#3897 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
==========================================
- Coverage 28.02% 28.00% -0.03%
==========================================
Files 70 70
Lines 3486 3489 +3
==========================================
Hits 977 977
- Misses 2447 2450 +3
Partials 62 62 ☔ View full report in Codecov by Sentry. |
- this allows using TLS but without verifying certificates/CAs/hostnames etc - fix e2e tests for new tlsInsecure parameter - add `// #nosec G402` so we can actually use InsecureSkipVerify - make gofumpt happy Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
force-pushed
the
add-tls-insecure
branch
from
e803be8 to
1fa6c71
Compare
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Jul 9, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Jul 9, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Jul 9, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
jacobweinstock
approved these changes
Jul 9, 2024
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Jul 11, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Jul 11, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Jul 11, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Jul 11, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Jul 11, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Jul 12, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Jul 20, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Jul 20, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Jul 21, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
mergify bot
added a commit
to tinkerbell/hook
that referenced
this pull request
Jul 23, 2024
…pass it to worker as TINKERBELL_INSECURE_TLS (#234) #### hook-bootkit: read `tinkerbell_insecure_tls` from kernel cmdline and pass it to worker as TINKERBELL_INSECURE_TLS - this fits in with - tinkerbell/smee#479 - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Jul 24, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Aug 3, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Aug 3, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Aug 4, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Aug 4, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Aug 5, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Aug 5, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Aug 5, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Aug 5, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Aug 17, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Aug 17, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Aug 17, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Aug 17, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Aug 17, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
added a commit
to rpardini/tinkerbell-smee
that referenced
this pull request
Aug 17, 2024
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
mergify bot
added a commit
to tinkerbell/smee
that referenced
this pull request
Aug 27, 2024
…ll_insecure_tls` kernel parameter (#479) #### smee: introduce bool `tink-server-insecure-tls` controlling `tinkerbell_insecure_tls` kernel parameter - for usage with `tink-worker`'s tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
jacobweinstock
pushed a commit
to rpardini/tinkerbell-charts
that referenced
this pull request
Oct 24, 2024
…ure-tls` - for usage combined with - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
mergify bot
added a commit
to tinkerbell/charts
that referenced
this pull request
Oct 24, 2024
…ure-tls` (#114) #### smee: add http.tinkServer.insecureTLS controlling `-tink-server-insecure-tls` - this fits in with - tinkerbell/smee#479 - tinkerbell/tink#960 - tinkerbell/hook#234 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tinkerbell-insecure-tls param to control InsecureSkipVerify
// #nosec G402so we can actually use InsecureSkipVerifySigned-off-by: Ricardo Pardini ricardo@pardini.net