smee: introduce bool tink-server-insecure-tls controlling tinkerbell_insecure_tls kernel parameter
#479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpardini
force-pushed
the
add-tink-insecure-tls-flag
branch
from
b9ea57b to
d6f150f
Compare
mergify bot
added a commit
to tinkerbell/hook
that referenced
this pull request
Jul 23, 2024
…pass it to worker as TINKERBELL_INSECURE_TLS (#234) #### hook-bootkit: read `tinkerbell_insecure_tls` from kernel cmdline and pass it to worker as TINKERBELL_INSECURE_TLS - this fits in with - tinkerbell/smee#479 - tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
force-pushed
the
add-tink-insecure-tls-flag
branch
2 times, most recently
from
df6f6c7 to
93f403f
Compare
…ll_insecure_tls` kernel parameter - for usage with tinkerbell/tink#960 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
force-pushed
the
add-tink-insecure-tls-flag
branch
from
93f403f to
7e803b4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
===================================
Coverage 52% 52%
===================================
Files 26 26
Lines 2136 2139 +3
===================================
+ Hits 1124 1126 +2
- Misses 980 981 +1
Partials 32 32 ☔ View full report in Codecov by Sentry. |
jacobweinstock
approved these changes
Aug 27, 2024
jacobweinstock
approved these changes
Aug 27, 2024
mergify bot
added a commit
to tinkerbell/charts
that referenced
this pull request
Oct 24, 2024
…ure-tls` (#114) #### smee: add http.tinkServer.insecureTLS controlling `-tink-server-insecure-tls` - this fits in with - tinkerbell/smee#479 - tinkerbell/tink#960 - tinkerbell/hook#234 Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smee: introduce bool
tink-server-insecure-tlscontrollingtinkerbell_insecure_tlskernel parametertink-worker's add tinkerbell-insecure-tls param to control InsecureSkipVerify tink#960Signed-off-by: Ricardo Pardini ricardo@pardini.net