Fix golangci-lint linter when multiple modules exist #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for golangci-lint when multiple modules are found but good practice anyway, thus why I'm adding to all the linters. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
There's not an overwhelming reason to avoid find for the single go module setup, it works as is for that case. By doing this it means that users won't have to remember to re-run lint-install if they go from 1 to >1 modules, which I doubt will happen if we keep them separate. Also, the less corner cases the better! Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
This was missed in b48895c. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
find -execdirto run golangci-lint to avoid an seldomly used corner case bit rottingWhy is this needed
Fixes: #39
Closes: #40
How Has This Been Tested?
Ran
make linta bunch in hook to make sure it works.How are existing users impacted? What migration steps/scripts do we need?
golangci-lint will actually run if multiple modules are detected (or added w/o having to re-run lint-install).