golangci-lint multi-module: Use $CURDIR to pin down execdir #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Stromberg <t+github@chainguard.dev>
mmlb
reviewed
Feb 16, 2022
| } | ||
|
|
||
| return fmt.Sprintf(`find . -name go.mod -execdir "$(GOLANGCI_LINT_BIN)" run -c "$(GOLINT_CONFIG)"%s \;`, suffix) | ||
| return fmt.Sprintf(`find . -name go.mod -execdir "$(CURDIR)/$(GOLANGCI_LINT_BIN)" run -c "$(GOLINT_CONFIG)"%s \;`, suffix) |
Contributor
There was a problem hiding this comment.
We already have LINT_ROOT which I think we should use instead of CURDIR, to avoid having 2 variables with similar values. Also, I think it would be better to update the TOOL_BIN variable(s) in Makefile.tmpl instead of fixing here. That way the Makefiles are where most of the logic lives and the go binary is mostly just dealing with enabling certain functionality. We wouldn't be mixing logic among 2 different processes/times ("buildtime" and "runtime"). We should probably just do this for all the binaries.
mmlb
added a commit
to mmlb/tinkerbell-hook
that referenced
this pull request
May 10, 2022
With fixes from tinkerbell/lint-install#40 applied manually. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
mmlb
added a commit
to mmlb/tinkerbell-hook
that referenced
this pull request
May 10, 2022
With fixes from tinkerbell/lint-install#40 applied manually. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
mmlb
added a commit
to mmlb/tinkerbell-hook
that referenced
this pull request
May 10, 2022
With fixes from tinkerbell/lint-install#40 applied manually. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
mmlb
added a commit
to mmlb/tinkerbell-hook
that referenced
this pull request
May 11, 2022
With fixes from tinkerbell/lint-install#40 applied manually. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Contributor
|
Hey @tstromberg I've opened up #45 with my version of these fixes. I also noticed that in multi-module mode no config file is actually used so fixed that too. I say lets go with #45 over this one, wdyt? |
mergify bot
added a commit
that referenced
this pull request
May 11, 2022
## Description * Uses full paths to executables, so changed dirs don't matter * Switches to always using `find -execdir` to run golangci-lint to avoid an seldomly used corner case bit rotting * Uses the correct variable name for the golangci-lint config file ## Why is this needed Fixes: #39 Closes: #40 ## How Has This Been Tested? Ran `make lint` a bunch in hook to make sure it works. ## How are existing users impacted? What migration steps/scripts do we need? golangci-lint will actually run if multiple modules are detected (or added w/o having to re-run lint-install).
mmlb
added a commit
to mmlb/tinkerbell-hook
that referenced
this pull request
May 11, 2022
With fixes from tinkerbell/lint-install#40 applied manually. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
mmlb
added a commit
to mmlb/tinkerbell-hook
that referenced
this pull request
May 16, 2022
With fixes from tinkerbell/lint-install#40 applied manually. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
mmlb
added a commit
to mmlb/tinkerbell-hook
that referenced
this pull request
May 16, 2022
With fixes from tinkerbell/lint-install#40 applied manually. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Stromberg t+github@chainguard.dev
Description
Fixes broken behavior with repositories containing multiple go packages. This change ensures that the successive find command are able to locate the path to golangci-lint properly.
Why is this needed
Fixes: #39
How Has This Been Tested?
Ran
make golangci-lint-lintin a repo containing ~40 go packages