Remove unnecessary bind mounts for linuxkit/dhcpcd #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Finneran <dan@thebsdbox.co.uk>
Contributor
|
Does this cause resolv.conf to not be updated then? |
Contributor
Author
|
@mmlb nope -> https://github.com/linuxkit/linuxkit/blob/master/pkg/dhcpcd/build.yml The |
Contributor
|
Please give this PR a title that can be used for release notes. I first read the title and assumed this PR was about removing a DNS server. |
tstromberg
changed the title
3 tasks
mergify bot
added a commit
that referenced
this pull request
Apr 23, 2022
## Description I was experiencing the same issue as [here](#79), but removing all the bind mounts didn't resolve it for me. However, adding the bind mounts back and creating the `/var/lib/dhcpcd` directory was the only way for me to get the interfaces to start working. With these changes the dhcpcd.log files were error free. Hey @thebsdbox. If you have any cycles, I'd be very interested to know if the `main: pidfile_lock: Permission denied` error still happens for you with this PR. Update dhcpcd onboot and service containers: Network interfaces were not coming up. Logs showed "`main: pidfile_lock: Permission denied`". Adding the bind mounts and directory creation resolved the issue. ## Why is this needed Fixes: # ## How Has This Been Tested? ## How are existing users impacted? What migration steps/scripts do we need? ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The removes the bind mounts for DHCP
Why is this needed
Causes DHCP to fail with a pidlock error, with DHCP broken tink-worker can never start.
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: