Push container images properly: #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way CI is built (2 self-hosted runners), CI was not pushing container images when building on main. This was because PR's would build the images and the would be locally in the Docker cache. Then when main ran, hook-lk-containers.sh would run and see that the image existed in the local Docker cache already and stop before pushing. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because of the way CI is built (2 self-hosted runners), CI was not pushing container images when building on main. This was because PR's would build the images and the would be locally in the Docker cache. Then when main ran, hook-lk containers.sh would run and see that the image existed in the local Docker cache already and stop before pushing.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: