Skip to content

Push container images properly: #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024
Merged

Push container images properly: #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions bash/hook-lk-containers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ function build_hook_linuxkit_container() {
log debug "Checking if image ${container_oci_ref} exists in local registry"
if [[ -n "$(docker images -q "${container_oci_ref}")" ]]; then
log info "Image ${container_oci_ref} exists in local registry, skipping build"
# we try to push here because a previous build may have created the image
# this is the case for GitHub Actions CI because we build PRs on the same self-hosted runner
push_hook_linuxkit_container "${container_oci_ref}"
return 0
fi

Expand All @@ -55,6 +58,15 @@ function build_hook_linuxkit_container() {

log info "Built ${container_oci_ref} from ${container_dir} for platform ${DOCKER_ARCH}"

push_hook_linuxkit_container "${container_oci_ref}"

return 0
}


function push_hook_linuxkit_container() {
declare container_oci_ref="${1}"

# Push the image to the registry, if DO_PUSH is set to yes
if [[ "${DO_PUSH}" == "yes" ]]; then
docker push "${container_oci_ref}" || {
Expand All @@ -64,6 +76,4 @@ function build_hook_linuxkit_container() {
else
log info "Skipping push of ${container_oci_ref} to registry; set DO_PUSH=yes to push."
fi

return 0
}