Clean up #150
Merged
Clean up #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a secure way to download a certificate. We need to figure out a better way to handle secrets across the netboot process. For now the certificate of the container registry must be signed by a known CA root. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
This allows insecure container registries to be used. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Member
Author
|
Hey @thebsdbox , would you mind checking this out when you have a moment. Please and thank you! |
Forward progress without the daemon.json is not desired behavior. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
mmlb
approved these changes
Nov 9, 2022
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 6d43b8b |
This was referenced Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looking to push through needed/desired code changes from PR #139 and #140. Remove insecure downloading of container registry certificate. Add the ability to specify insecure registries for use in the docker container engine config.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: