Skip downloading the cert if tinkServerTLS is not enabled #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokearu
reviewed
Aug 31, 2022
|
|
||
| path := fmt.Sprintf("/etc/docker/certs.d/%s/", cfg.registry) | ||
| // if tinkServerTLS is not enabled, skip downloading the certs | ||
| if cfg.tinkServerTLS { |
There was a problem hiding this comment.
Should this not be set in parseCmdLine?
Contributor
There was a problem hiding this comment.
I say we just get rid of this. Fetching the certs is very likely to be done in an unsafe manner and we're better off not making it easy to shoot your foot.
Signed-off-by: Abhinav Pandey <abhinavmpandey08@gmail.com>
jacobweinstock
requested changes
Sep 16, 2022
| baseURL string | ||
| tinkerbell string | ||
| syslogHost string | ||
| tinkServerTLS bool |
Member
There was a problem hiding this comment.
doesn't look like this value is being set anywhere. You might want to add to parseCmdLine.
Member
|
This functionality now exist in main via #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip downloading the cert if
tinkServerTLSis not enabledWhy is this needed
New Tinkerbell stack doesn't host the cert anymore. I'm making it optional so it allows users to skip this process without breaking compatibility
Fixes: #
How Has This Been Tested?
Setup hook with
tinkServerTLSto false and ensured that the cert doesn't get pulledHow are existing users impacted? What migration steps/scripts do we need?
Shouldn't affect existing users but they can set this flag explicitly to download/skip cert download
Checklist:
I have: