Update all the things! #125
Conversation
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Mostly just for visibility into timing. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
I couldn't figure out a max line length and so decided one-sentence-per-line. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
mmlb
force-pushed
the
update-all-the-things
branch
from
8727cc6 to
926fdda
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| if err == nil { | ||
| break | ||
| } | ||
| resp.Body.Close() |
There was a problem hiding this comment.
G104: Errors unhandled.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
mmlb
force-pushed
the
update-all-the-things
branch
from
926fdda to
1593745
Compare
| if err == nil { | ||
| break | ||
| } | ||
| resp.Body.Close() |
There was a problem hiding this comment.
G104: Errors unhandled.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| if err == nil { | ||
| break | ||
| } | ||
| resp.Body.Close() |
There was a problem hiding this comment.
G104: Errors unhandled.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
mmlb
force-pushed
the
update-all-the-things
branch
from
8bad1d4 to
8974c12
Compare
| if err == nil { | ||
| break | ||
| } | ||
| resp.Body.Close() |
There was a problem hiding this comment.
G104: Errors unhandled.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
mmlb
force-pushed
the
update-all-the-things
branch
from
8974c12 to
dd4f190
Compare
| if err == nil { | ||
| break | ||
| } | ||
| resp.Body.Close() |
There was a problem hiding this comment.
G104: Errors unhandled.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
mmlb
force-pushed
the
update-all-the-things
branch
from
dd4f190 to
248c0c6
Compare
README.md
Outdated
| [osie]: https://github.com/tinkebell/osie | ||
| [sandbox]: https://github.com/tinkerbell/sandbox | ||
| [specification]: https://github.com/linuxkit/linuxkit/blob/master/docs/yaml.md | ||
| [tinkerbe]: https://tinkerbell.org |
| if err == nil { | ||
| break | ||
| } | ||
| resp.Body.Close() |
There was a problem hiding this comment.
G104: Errors unhandled.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Avoids repitition and long lines. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
With fixes from tinkerbell/lint-install#40 applied manually. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Still builds, soI guess...? Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
mmlb
force-pushed
the
update-all-the-things
branch
from
248c0c6 to
f8e1ab4
Compare
| if err == nil { | ||
| break | ||
| } | ||
| resp.Body.Close() |
There was a problem hiding this comment.
G104: Errors unhandled.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
2 participants
Description
Updates all the things that we use in hook (except the kernel). This sort of started because of #105 where tests failed because of latest
make lintwhich wanted go1.17 and we've been wanting to update to that anyway and well here we are.Why is this needed
I was rebasing #105 and noticed that I had a bunch of non-Makefile stuff there including some stuff I hadn't pushed yet (go update). So I broke it out to this PR instead.
How Has This Been Tested?
make lintworks, andmake devdoes too.How are existing users impacted? What migration steps/scripts do we need?
Nicer looking code.