Skip to content

Conversation

@TimTheBig
Copy link
Contributor

@TimTheBig TimTheBig commented Mar 28, 2025

This is part 1 of #36, it will:

  • Document all modules and structs.
  • Move main.rs to examples/, split for maximum usefulness. And the example shape functions to a mod behind a the shapes feature.
  • Move shapes in readme to separate file
  • Add error types and handling

@TimTheBig TimTheBig mentioned this pull request Apr 10, 2025
@timschmidt
Copy link
Owner

Do you have Discord, Signal, IRC, or some other way to chat interactively? I'd like to discuss some of this.

@TimTheBig
Copy link
Contributor Author

TimTheBig commented Apr 11, 2025

Do you have Discord, Signal, IRC, or some other way to chat interactively? I'd like to discuss some of this.

Signal not sure how to share it privately

@timschmidt
Copy link
Owner

my email is timschmidt at gmail. You can send it there.

@TimTheBig
Copy link
Contributor Author

TimTheBig commented Apr 12, 2025

Remaining tasks:

  • Document the rest of the data-structures and modules
  • Move the rest of the examples
  • Cleanup readme, moving some info to other files
  • Make offset also act on projected 3d polygons

@timschmidt
Copy link
Owner

@timschmidt did you get the email I sent?

not yet

@TimTheBig
Copy link
Contributor Author

I sent it to the wrong email, you should have it now

@timschmidt
Copy link
Owner

Received. Message sent.

@TimTheBig TimTheBig marked this pull request as ready for review April 20, 2025 19:14
@TimTheBig
Copy link
Contributor Author

This ready the remaining tasks will be addressed in a future pr, please release a new version after this pr is merged.

@TimTheBig
Copy link
Contributor Author

I will fix conflicts tomorrow

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace with csgrs-generated graphic or remove.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace with csgrs-generated graphic or remove.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace with csgrs-generated graphic or remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave it out for now, same for all above

Copy link

@recurseml recurseml bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by RecurseML

🔍 Review performed on 85f0871..3dbadc3

  Severity     Location     Issue     Delete  
Low src/shapes2d.rs:472 Inconsistent type conversion pattern
✅ Files analyzed, no issues (45)

.gitignore
Cargo.lock
Cargo.toml
docs/convex_hull.svg
examples/basic2d_shapes_and_offsetting.rs
examples/basic_shapes.rs
examples/boolean_operations.rs
examples/convex_hull.rs
examples/extrude.rs
examples/mass_properties.rs
examples/metaballs.rs
examples/metadata.rs
examples/minkowski_sum.rs
examples/polyhedron.rs
examples/ray_intersection.rs
examples/renormalize.rs
examples/sdf.rs
examples/subdivide_triangles.rs
examples/text.rs
examples/transformations.rs
readme.md
shapes.md
src/bsp.rs
src/convex_hull.rs
src/csg.rs
src/csg_io.rs
src/errors.rs
src/extrudes.rs
src/flatten_slice.rs
src/float_types.rs
src/hershey.rs
src/io/image.rs
src/io/mod.rs
src/io/svg.rs
src/lib.rs
src/main.rs
src/metaballs.rs
src/offset.rs
src/plane.rs
src/polygon.rs
src/sdf.rs
src/shapes3d.rs
src/tests.rs
src/truetype.rs
typos.toml

let step = delta / (arc_segments_per_side as Real);
for seg_i in 0..arc_segments_per_side {
let step = delta / (Into::<usize>::into(arc_segments_per_side) as Real);
for seg_i in 0..(arc_segments_per_side.into()) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent conversion pattern. On line 471, arc_segments_per_side is converted to usize via Into::<usize>::into(arc_segments_per_side), but on line 472, it uses .into(). While both work, this inconsistency suggests potential confusion about the type handling. More importantly, the loop range should use arc_segments_per_side.get() for clarity and to avoid unnecessary trait resolution.


React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants