-
-
Notifications
You must be signed in to change notification settings - Fork 24
Allow for geo-3d integration – Part 1: Refactor and Document
#44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Since no_run compiles but doesn't run.
and document sdf
Also improve use of compile-time guaranties
|
Do you have Discord, Signal, IRC, or some other way to chat interactively? I'd like to discuss some of this. |
Signal not sure how to share it privately |
|
my email is timschmidt at gmail. You can send it there. |
|
Remaining tasks:
|
not yet |
|
I sent it to the wrong email, you should have it now |
|
Received. Message sent. |
|
This ready the remaining tasks will be addressed in a future pr, please release a new version after this pr is merged. |
|
I will fix conflicts tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace with csgrs-generated graphic or remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace with csgrs-generated graphic or remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace with csgrs-generated graphic or remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will leave it out for now, same for all above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by RecurseML
🔍 Review performed on 85f0871..3dbadc3
| Severity | Location | Issue | Delete |
|---|---|---|---|
| src/shapes2d.rs:472 | Inconsistent type conversion pattern |
✅ Files analyzed, no issues (45)
• .gitignore
• Cargo.lock
• Cargo.toml
• docs/convex_hull.svg
• examples/basic2d_shapes_and_offsetting.rs
• examples/basic_shapes.rs
• examples/boolean_operations.rs
• examples/convex_hull.rs
• examples/extrude.rs
• examples/mass_properties.rs
• examples/metaballs.rs
• examples/metadata.rs
• examples/minkowski_sum.rs
• examples/polyhedron.rs
• examples/ray_intersection.rs
• examples/renormalize.rs
• examples/sdf.rs
• examples/subdivide_triangles.rs
• examples/text.rs
• examples/transformations.rs
• readme.md
• shapes.md
• src/bsp.rs
• src/convex_hull.rs
• src/csg.rs
• src/csg_io.rs
• src/errors.rs
• src/extrudes.rs
• src/flatten_slice.rs
• src/float_types.rs
• src/hershey.rs
• src/io/image.rs
• src/io/mod.rs
• src/io/svg.rs
• src/lib.rs
• src/main.rs
• src/metaballs.rs
• src/offset.rs
• src/plane.rs
• src/polygon.rs
• src/sdf.rs
• src/shapes3d.rs
• src/tests.rs
• src/truetype.rs
• typos.toml
| let step = delta / (arc_segments_per_side as Real); | ||
| for seg_i in 0..arc_segments_per_side { | ||
| let step = delta / (Into::<usize>::into(arc_segments_per_side) as Real); | ||
| for seg_i in 0..(arc_segments_per_side.into()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent conversion pattern. On line 471, arc_segments_per_side is converted to usize via Into::<usize>::into(arc_segments_per_side), but on line 472, it uses .into(). While both work, this inconsistency suggests potential confusion about the type handling. More importantly, the loop range should use arc_segments_per_side.get() for clarity and to avoid unnecessary trait resolution.
React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)
This is part 1 of #36, it will:
main.rstoexamples/, split for maximum usefulness. And the example shape functions to a mod behind a the shapes feature.