-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bot for Github actions #49
Conversation
65090bd
to
52a2d78
Compare
52a2d78
to
281b1e3
Compare
dcdd5e1
to
b1db5b6
Compare
edb89e3
to
0e3084c
Compare
b52f3ba
to
0f3cd46
Compare
0f3cd46
to
a0fa8fd
Compare
4d88fa8
to
2bec05c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@KristofferC @timholy response to a couple of comments: I am assuming that the users of this package are following the rules I set and specified in the documentation, and so the code works for these situations. Handling all the other possibilities does not have much value. For example: To make the whole code independent of the current working directory and where packages files are placed a couple of things should be done. packagePath = Base.read(`cmd /c julia -e 'import MatLang; print(pathof(MatLang))'`, String) packagePath = joinpath(pwd(),"src","$packageName.jl") or for or if the user decides to have multiple precompile inclusion by mistake, such as: # include("precompile.jl")
# _precompile_()
# some other stuff
include("precompile.jl")
_precompile_() The code will not work. |
v2.0.0 pull request bot pathof timholy#49 (comment) rename snoopiBenchBot ro snoopiBench timholy#49 (comment) Doc reference Fixes timholy#49 (comment) Naming convention =@. timholy#49 (comment) Benchmarking the infer time of the tests timholy#49 (comment) code quoting const UStrings timholy#49 (comment) timholy#49 (comment) file name typo timholy#49 (comment) Link updated timholy#49 (comment) typo timholy#49 (comment) __precompile__ timholy#49 (comment) Base.read and Base.write timholy#49 (comment) timholy#49 (comment) UString timholy#49 (comment) precompile include clarification timholy#49 (comment) Experimental timholy#49 (comment) Using isfile timholy#49 (comment) test dep Clarification timholy#49 (comment) and timholy#49 (comment) Comitter comment Fixes timholy#49 (comment)
v2.0.0 pull request bot pathof timholy#49 (comment) rename snoopiBenchBot ro snoopiBench timholy#49 (comment) Doc reference Fixes timholy#49 (comment) Naming convention =@. timholy#49 (comment) Benchmarking the infer time of the tests timholy#49 (comment) code quoting const UStrings timholy#49 (comment) timholy#49 (comment) file name typo timholy#49 (comment) Link updated timholy#49 (comment) typo timholy#49 (comment) __precompile__ timholy#49 (comment) Base.read and Base.write timholy#49 (comment) timholy#49 (comment) UString timholy#49 (comment) precompile include clarification timholy#49 (comment) Experimental timholy#49 (comment) Using isfile timholy#49 (comment) test dep Clarification timholy#49 (comment) and timholy#49 (comment) Comitter comment Fixes timholy#49 (comment) Base.write instead of (de)activated.jl in tests Fixes timholy#49 (comment)
I can maintain the code. Should I remove "EXPERIMENTAL"? |
v2.0.0 pull request bot pathof timholy#49 (comment) rename snoopiBenchBot ro snoopiBench timholy#49 (comment) Doc reference Fixes timholy#49 (comment) Naming convention =@. timholy#49 (comment) Benchmarking the infer time of the tests timholy#49 (comment) code quoting const UStrings timholy#49 (comment) timholy#49 (comment) file name typo timholy#49 (comment) Link updated timholy#49 (comment) typo timholy#49 (comment) __precompile__ timholy#49 (comment) Base.read and Base.write timholy#49 (comment) timholy#49 (comment) UString timholy#49 (comment) precompile include clarification timholy#49 (comment) Experimental timholy#49 (comment) Using isfile timholy#49 (comment) test dep Clarification timholy#49 (comment) and timholy#49 (comment) Comitter comment Fixes timholy#49 (comment) Base.write instead of (de)activated.jl in tests Fixes timholy#49 (comment)
v2.0.0 pull request bot pathof timholy#49 (comment) rename snoopiBenchBot ro snoopiBench timholy#49 (comment) Doc reference Fixes timholy#49 (comment) Naming convention =@. timholy#49 (comment) Benchmarking the infer time of the tests timholy#49 (comment) code quoting const UStrings timholy#49 (comment) timholy#49 (comment) file name typo timholy#49 (comment) Link updated timholy#49 (comment) typo timholy#49 (comment) __precompile__ timholy#49 (comment) Base.read and Base.write timholy#49 (comment) timholy#49 (comment) UString timholy#49 (comment) precompile include clarification timholy#49 (comment) Experimental timholy#49 (comment) Using isfile timholy#49 (comment) test dep Clarification timholy#49 (comment) and timholy#49 (comment) Comitter comment Fixes timholy#49 (comment) Base.write instead of (de)activated.jl in tests Fixes timholy#49 (comment) accurate error message timholy#49 (comment)
@timholy This is ready. Should I do anything else? |
Let's do it! Thanks for a huge contribution!
Let's leave it as an insurance policy. |
Version 1.2 is out: JuliaRegistries/General#7894 Care to do the honors of writing a discourse post? |
Awesome! I would be happy to write a post 🚀 |
Adds support for #37
These are some utilities that I will be using for the SnoopCompile bot. I think the best place for these functions is the SnoopCompile itself.