SnoopCompile

[aminya]

Ready to get merged

Atom infer time is enhanced by 19% 🚀

[pfitzseb]

Can you check by how much does this improve package load times/time to first eval?

I was under the impression that precompile statements that reach into dependencies don't really work (i.e. aren't cached in ji files), so it's possible that most of the files added here won't make much of a difference.

[aminya]

Yes, only "deps/SnoopCompile/precompile/precompile_Atom.jl" is added to precompile now.
I added other files just for the record.

[aminya]

Also, ideally this should run by Travis and the jl files inside precompile folder should be updated. I ran this on the latest registered version.

[pfitzseb]

Oh ok, I didn't scroll down all the way :)

So I guess we'd ideally merge this, open PRs against the bigger dependencies (JSON, Tokenize and CSTParser, probably), and get rid of a bunch of random dependencies (Hiccup, Media, CodeTools, Lazy).

I'll play around with this a bit later today or tomorrow, but thanks for taking the initiative on this! :)

[aviatesk]

just for info: we should care about this kind of regression: bicycle1885/TableReader.jl#58

[aminya]

Can you guys run the benchmark from the file that I added? I have a hard time running the benchmark from outside of the Atom. Running it from inside the atom gives the wrong information as it is already loaded.

[aminya]

just for info: we should care about this kind of regression: bicycle1885/TableReader.jl#58

I added an issue for creating a Github action to automatically update the precompile files
timholy/SnoopCompile.jl#37

[aviatesk]

Yes, only "deps/SnoopCompile/precompile/precompile_Atom.jl" is added to precompile now.
I added other files just for the record.

could you please ignore/rm those files ? They look pretty messy as is.

[aminya]

Yes, only "deps/SnoopCompile/precompile/precompile_Atom.jl" is added to precompile now.
I added other files just for the record.

could you please ignore/rm those files ? They look pretty messy as is.

Cleaned up ♻️

[aminya]

I added Github actions for automatically creating the precompile file. Could you guys test it?

[aminya]

The test is passed here:
https://github.com/aminya/Atom.jl/commit/d127e7360362a0485ba598c830b330ab088cecc2/checks?check_suite_id=355123378

I think now you can merge this.

[codecov]

Codecov Report

Merging #225 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   46.07%   46.07%           
=======================================
  Files          40       40           
  Lines        1910     1910           
=======================================
  Hits          880      880           
  Misses       1030     1030

Impacted Files	Coverage Δ
src/Atom.jl	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbb812...06601ab. Read the comment docs.

[aminya]

I fixed the issue by test_skiping one of the tests. However, there are still a couple of precompile sentences to filter out

[aminya]

When I add precompilation sentences generated by Atom some of the tests fail (from modules.jl and goto.jl).

https://github.com/aminya/Atom.jl/commit/6aadc52f978fef0ebefa0c115364e8458482ddce/checks?check_suite_id=379165136

[aminya]

Yay! the problem is fixed. Atom infer time is enhanced by 19% 🚀
The PR can be merged now

https://github.com/aminya/Atom.jl/runs/409940740?check_suite_focus=true

I didn't benchmark the actual timing but infer time is reduced by 3.6s which is 19%.