Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix tso fallback due raft cluster did not stop tso service (part2) (#8885) #8890

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8885

What problem does this PR solve?

Issue Number: Close #8889 ref #8477

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

…part2)

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 10, 2024
Signed-off-by: lhy1024 <admin@liudos.us>
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, expect for the linter issue.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 10, 2024
Signed-off-by: lhy1024 <admin@liudos.us>
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.59%. Comparing base (3994172) to head (4901b60).
Report is 3 commits behind head on release-8.5.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-8.5    #8890   +/-   ##
============================================
  Coverage        75.59%   75.59%           
============================================
  Files              461      462    +1     
  Lines            72296    72355   +59     
============================================
+ Hits             54655    54700   +45     
- Misses           14140    14162   +22     
+ Partials          3501     3493    -8     
Flag Coverage Δ
unittests 75.59% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-10 11:02:31.36422584 +0000 UTC m=+349941.453028383: ☑️ agreed by rleungx.
  • 2024-12-10 11:18:42.421870489 +0000 UTC m=+350912.510673032: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit d190c0e into tikv:release-8.5 Dec 10, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants