-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: fix tso fallback due raft cluster did not stop tso service (part2) (#8885) #8890
cluster: fix tso fallback due raft cluster did not stop tso service (part2) (#8885) #8890
Conversation
…part2) Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, expect for the linter issue.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #8890 +/- ##
============================================
Coverage 75.59% 75.59%
============================================
Files 461 462 +1
Lines 72296 72355 +59
============================================
+ Hits 54655 54700 +45
- Misses 14140 14162 +22
+ Partials 3501 3493 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #8885
What problem does this PR solve?
Issue Number: Close #8889 ref #8477
What is changed and how does it work?
Check List
Tests
Release note