Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/tso: fix the issue where the TSO follower proxy cannot be closed (#8719) #8721

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8719

What problem does this PR solve?

Issue Number: close #8709.

What is changed and how does it work?

Remove outdated follower connections after disabling the TSO follower proxy.

Check List

Tests

  • Unit test
  • Integration test

Release note

Fix the issue where the TSO follower proxy cannot be closed.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot added component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4 labels Oct 16, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (697d907) to head (5e88582).
Report is 1 commits behind head on release-8.4.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.4    #8721      +/-   ##
===============================================
+ Coverage        71.72%   71.75%   +0.03%     
===============================================
  Files              517      517              
  Lines            67450    67452       +2     
===============================================
+ Hits             48377    48400      +23     
+ Misses           15504    15493      -11     
+ Partials          3569     3559      -10     
Flag Coverage Δ
unittests 71.75% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 16, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-16 06:52:46.112072373 +0000 UTC m=+426763.260982203: ☑️ agreed by JmPotato.
  • 2024-10-16 07:16:14.103309062 +0000 UTC m=+428171.252218888: ☑️ agreed by okJiang.

Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 2d8f681 into tikv:release-8.4 Oct 16, 2024
22 of 23 checks passed
@JmPotato JmPotato deleted the cherry-pick-8719-to-release-8.4 branch October 16, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants