Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSO follower proxy still effective after disabling it #8709

Closed
MyonKeminta opened this issue Oct 15, 2024 · 0 comments · Fixed by #8719
Closed

TSO follower proxy still effective after disabling it #8709

MyonKeminta opened this issue Oct 15, 2024 · 0 comments · Fixed by #8719
Assignees
@JmPotato
Labels
affects-8.4 severity/critical type/bug The issue is confirmed as a bug.

Comments

@MyonKeminta
Copy link
Contributor

MyonKeminta commented Oct 15, 2024 •
edited
Loading

Bug Report

What did you do?

In TiDB, while running any workload, enable TSO follower proxy and then disable it via system variable..

What did you expect to see?

The TSO follower proxy behavior stops after disabling TSO follower proxy

What did you see instead?

TSO follower looks still effective after disabling it. This can make the performace slighly lower than that before enabling it.

image
image

What version of PD are you using (pd-server -V)?

TiDB: a21d9ea447cea626c897acaa982ce63b88eada5e
TiKV: 18546c296bc70e4abf2ab144b1f3048dbc47024e
PD: 982fa22

(The issue seems to be in pd client referenced by TiDB, not pd server).
@MyonKeminta MyonKeminta added the type/bug The issue is confirmed as a bug. label Oct 15, 2024
@JmPotato JmPotato self-assigned this Oct 15, 2024
@JmPotato JmPotato mentioned this issue Oct 16, 2024
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in b70107e Oct 16, 2024
@ti-chi-bot ti-chi-bot mentioned this issue Oct 16, 2024
Merged
@JmPotato JmPotato mentioned this issue Oct 16, 2024
Closed
ti-chi-bot bot pushed a commit that referenced this issue Oct 16, 2024
@ti-chi-bot @JmPotato
client/tso: fix the issue where the TSO follower proxy cannot be clos…
2d8f681 
…ed (#8719) (#8721)

close #8709

Remove outdated follower connections after disabling the TSO follower proxy.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmPotato JmPotato

Labels
affects-8.4 severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client/tso: fix the issue where the TSO follower proxy cannot be closed JmPotato/pd
2 participants
@JmPotato @MyonKeminta