Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_control: allow configuration of the maximum retry time for the local bucket (#8352) #8365

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jul 4, 2024

What problem does this PR solve?

Issue Number: Close #8349

What is changed and how does it work?

resource_control: allow configuration of the maximum retry time for the local bucket
- Added config `ltb-token-rpc-max-delay`
- Increased default max delay from 500ms to 1s

Check List

Tests

  • Unit test
  • Integration test

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2024
@nolouch nolouch changed the title resource_control: allow configuration of the maximum retry time for the local bucket resource_control: allow configuration of the maximum retry time for the local bucket (#8352) Jul 4, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2024
ti-chi-bot and others added 2 commits July 4, 2024 17:21
…ucket (tikv#8344) (tikv#8355)

close tikv#8343, ref tikv#8349

client/controller: record context error and add slowlog about token bucket
- record low process start time, and log it if it's too slow
- record the context error

Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>
close tikv#8349

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 4, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HuSharp, JmPotato
Once this PR has been reviewed and has the lgtm label, please assign easonn7 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-04 09:36:48.235789812 +0000 UTC m=+1489934.721278645: ☑️ agreed by JmPotato.
  • 2024-07-04 09:51:53.5543717 +0000 UTC m=+1490840.039860531: ☑️ agreed by HuSharp.

@nolouch nolouch merged commit 173c2e1 into tikv:release-7.5-20240704-v7.5.2 Jul 4, 2024
20 of 21 checks passed
@nolouch nolouch deleted the apply-issue-8349 branch July 4, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants