-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: remove leak option #7777
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
2475d52
to
580a77d
Compare
51b2fc2
to
4581dd2
Compare
30ddb17
to
f87e9bb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7777 +/- ##
==========================================
+ Coverage 73.45% 73.59% +0.14%
==========================================
Files 432 433 +1
Lines 47843 47871 +28
==========================================
+ Hits 35142 35230 +88
+ Misses 9663 9620 -43
+ Partials 3038 3021 -17
Flags with carried forward coverage won't be shown. Click here to find out more. |
a8e2b09
to
3b90e9b
Compare
fc9ab98
to
654845c
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: Close #7782
What is changed and how does it work?
for example, we will meet goroutine leak which top stack is
runtime_pollWait
which resulted fromdashboard
besides we will meet goroutine leak error which top stack is
runtime_pollWait
as well, but the root case isgo.etcd.io/etcd/pkg/transport.timeoutConn.Read
which is different withdashboard
When we use top stack to ignore, it results in dashboard errors not being exposed.
A better way to treat these two issues is to:
So we need a more fine-grained to check
Check List
Tests
Code changes
Release note