-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: update the leader even if the connection creation fails (#7443) #7473
client: update the leader even if the connection creation fails (#7443) #7473
Conversation
close tikv#7416 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.1 #7473 +/- ##
===============================================
+ Coverage 75.39% 75.47% +0.08%
===============================================
Files 308 308
Lines 30591 30601 +10
===============================================
+ Hits 23063 23097 +34
+ Misses 5516 5497 -19
+ Partials 2012 2007 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is a special case, not solved in the release branch |
This is an automated cherry-pick of #7443
What problem does this PR solve?
Issue Number: Close #7416
What is changed and how does it work?
update the leader even if the connection creation fails.
If connection is nil, consider it as networkErr
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note