Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use independent lock (#5587) #5635

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5587

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #5586.

What is changed and how does it work?

This PR split the basic cluster lock into two and move out some logic from the lock section in the region heartbeat.

Check List

Tests

  • Manual test

Test via 1000K Region/40 Store/1PD

8e18727

Update speed of each category:
  Requests/sec:     41370.8813
  Save-Tree/sec:     2482.2529
  Save-KV/sec:       1654.8353
  Save-Space/sec:    6205.6322
  Save-Flow/sec:    14479.8085
  Skip/sec:         20627.0333

7d128cb

Update speed of each category:
  Requests/sec:     34475.6364
  Save-Tree/sec:     2068.5382
  Save-KV/sec:       1379.0255
  Save-Space/sec:    5171.3455
  Save-Flow/sec:    12066.4727
  Skip/sec:         17189.1455

master:

Update speed of each category:
  Requests/sec:     25145.4940
  Save-Tree/sec:     1508.7296
  Save-KV/sec:       1005.8198
  Save-Space/sec:    3771.8241
  Save-Flow/sec:     8800.9229
  Skip/sec:         12537.2466

Release note

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Oct 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. do-not-merge/cherry-pick-not-approved labels Oct 25, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 14, 2022
server/cluster/cluster.go Outdated Show resolved Hide resolved
@rleungx rleungx force-pushed the cherry-pick-5587-to-release-6.1 branch from 2f8f8a7 to c340f45 Compare November 22, 2022 05:48
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 75.49% // Head: 75.55% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (c340f45) compared to base (24dcebb).
Patch coverage: 91.71% of modified lines in pull request are covered.

❗ Current head c340f45 differs from pull request most recent head f02f21f. Consider uploading reports for the commit f02f21f to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.1    #5635      +/-   ##
===============================================
+ Coverage        75.49%   75.55%   +0.06%     
===============================================
  Files              307      307              
  Lines            30426    30440      +14     
===============================================
+ Hits             22970    22999      +29     
+ Misses            5467     5455      -12     
+ Partials          1989     1986       -3     
Flag Coverage Δ
unittests 75.55% <91.71%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cluster/cluster.go 82.63% <83.33%> (-0.54%) ⬇️
server/core/basic_cluster.go 90.99% <91.89%> (-0.43%) ⬇️
server/core/region.go 91.48% <100.00%> (+0.01%) ⬆️
server/core/region_tree.go 94.16% <100.00%> (ø)
pkg/tempurl/tempurl.go 60.00% <0.00%> (-10.00%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/election/lease.go 84.05% <0.00%> (-1.45%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/server.go 72.95% <0.00%> (-1.11%) ⬇️
pkg/btree/btree.go 86.26% <0.00%> (-0.97%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rleungx rleungx force-pushed the cherry-pick-5587-to-release-6.1 branch from c340f45 to f5e1725 Compare November 22, 2022 06:18
ref tikv#5586

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the cherry-pick-5587-to-release-6.1 branch from f5e1725 to f02f21f Compare November 22, 2022 08:19
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2022
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Nov 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2022
@nolouch
Copy link
Contributor

nolouch commented Nov 25, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: f02f21f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2022
@ti-chi-bot ti-chi-bot merged commit 1a4e975 into tikv:release-6.1 Nov 25, 2022
@nolouch nolouch mentioned this pull request Nov 30, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants