-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce locking contention for region heartbeat handling #5586
Labels
affects-6.1
severity/minor
type/bug
The issue is confirmed as a bug.
type/enhancement
The issue or PR belongs to an enhancement.
Comments
For 1, I think the purpose of this lock is that we wanna keep the atomicity of the whole progress of updating the cache. And both 2 and 3 are good choices. |
Related to #3557 |
ti-chi-bot
added a commit
that referenced
this issue
Oct 25, 2022
ref #5586 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Oct 25, 2022
ref tikv#5586 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Merged
ti-chi-bot
added a commit
that referenced
this issue
Oct 27, 2022
ref #5586 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
This was referenced Oct 28, 2022
More details task list here: #5648 |
rleungx
added a commit
to ti-chi-bot/pd
that referenced
this issue
Nov 22, 2022
ref tikv#5586 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
rleungx
added a commit
to ti-chi-bot/pd
that referenced
this issue
Nov 22, 2022
ref tikv#5586 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
rleungx
added a commit
to ti-chi-bot/pd
that referenced
this issue
Nov 22, 2022
ref tikv#5586 Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot
added a commit
that referenced
this issue
Nov 25, 2022
15 tasks
ti-chi-bot
added a commit
that referenced
this issue
Nov 30, 2022
Close it for now since #5648 is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-6.1
severity/minor
type/bug
The issue is confirmed as a bug.
type/enhancement
The issue or PR belongs to an enhancement.
Enhancement Task
we are running a tidb cluster to host about 90TB data on 1.8m regions, and seeing significant locking contention that causes 2 issues when there are massive region movement, i.e. when scales out tikv.
dig into pd code, the locks has coarse scope and could be improved to increase the throughput. for example,
BasicCluster
could only lock thing based on its business needs, and using lock-free or thread-safe data structure instead of lock at high-level, for example, a thread-safe b-tree could have a lock for each node instead of lock the whole tree.The text was updated successfully, but these errors were encountered: