Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: reset stores cache before loading cluster info (#4942) #4955

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4942

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Close #4941.

What is changed and how does it work?

This PR resets the new leader store cache after transferring the PD leader.

Check List

Tests

  • Unit test

Release note

Fix the issue that the removed tombstone store shows again after transferring the PD leader

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 16, 2022
@ti-chi-bot ti-chi-bot added component/cluster Cluster logic. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick. labels May 16, 2022
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 13, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #4955 (7fcbf52) into release-5.0 (961a7a0) will decrease coverage by 0.06%.
The diff coverage is 80.00%.

@@               Coverage Diff               @@
##           release-5.0    #4955      +/-   ##
===============================================
- Coverage        74.97%   74.90%   -0.07%     
===============================================
  Files              245      245              
  Lines            24463    24467       +4     
===============================================
- Hits             18341    18327      -14     
- Misses            4506     4515       +9     
- Partials          1616     1625       +9     
Flag Coverage Δ
unittests 74.90% <80.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cluster/cluster.go 82.04% <50.00%> (-0.63%) ⬇️
server/core/basic_cluster.go 90.96% <100.00%> (+0.17%) ⬆️
pkg/dashboard/adapter/manager.go 82.97% <0.00%> (-7.45%) ⬇️
server/region_syncer/client.go 79.68% <0.00%> (-3.91%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/tso/tso.go 74.54% <0.00%> (-2.43%) ⬇️
server/core/storage.go 67.68% <0.00%> (-2.29%) ⬇️
server/schedule/operator/step.go 68.76% <0.00%> (-1.27%) ⬇️
server/server.go 71.21% <0.00%> (-1.05%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 961a7a0...7fcbf52. Read the comment docs.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 18, 2022
@nolouch
Copy link
Contributor

nolouch commented Jul 18, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 8e853f7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2022
@ti-chi-bot ti-chi-bot merged commit 92c41c0 into tikv:release-5.0 Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/cluster Cluster logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants