Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed tombstone stores show again if transfer pd leader during scale in #4941

Closed
mayjiang0203 opened this issue May 12, 2022 · 4 comments · Fixed by #4942
Closed

Removed tombstone stores show again if transfer pd leader during scale in #4941

mayjiang0203 opened this issue May 12, 2022 · 4 comments · Fixed by #4942

Comments

@mayjiang0203
Copy link

Bug Report

What did you do?

Test steps:

  1. Offline one store name as StoreA;
  2. During the offline, transfer pd leader from A to B;
  3. After offline finished, use pd-ctl delete tombstone nodes;
  4. Tansfer PD leader from B to A, check stores list.

What did you expect to see?

In step 4, no StoreA show.

What did you see instead?

StoreA show as disconnected as below.
{
"store": {
"id": 24439739,
"address": "tc-tikv-3.tc-tikv-peer.testbed-oltp-hm-fv98h.svc:20160",
"version": "6.0.0-alpha",
"status_address": "0.0.0.0:20180",
"git_hash": "4476e273804abe376b5fbcf0a7cbd43856de0b8f",
"start_timestamp": 1652358299,
"deploy_path": "/",
"last_heartbeat": 1652358589051981647,
"state_name": "Disconnected"
},
"status": {
"capacity": "1.465TiB",
"available": "1.436TiB",
"used_size": "29.6GiB",
"leader_count": 517,
"leader_weight": 1,
"leader_score": 517,
"leader_size": 48083,
"region_count": 616,
"region_weight": 1,
"region_score": 71515.07450951572,
"region_size": 60006,
"slow_score": 1,
"receiving_snap_count": 4,
"start_ts": "2022-05-12T12:24:59Z",
"last_heartbeat_ts": "2022-05-12T12:29:49.051981647Z",
"uptime": "4m50.051981647s"
}
}
]
}

What version of PD are you using (pd-server -V)?

/ # /pd-server -V
Release Version: v6.1.0-nightly
Edition: Community
Git Commit Hash: 6554d63
Git Branch: heads/refs/tags/v6.1.0-nightly
UTC Build Time: 2022-05-11 10:56:02

@mayjiang0203 mayjiang0203 added the type/bug The issue is confirmed as a bug. label May 12, 2022
@mayjiang0203
Copy link
Author

/severity Major
/assign @rleungx
/found automation

@ti-chi-bot
Copy link
Member

@mayjiang0203: There are no type labels on this issue. Please add an appropriate label by using the following command:

  • /type <type-name>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nolouch nolouch added type/bug The issue is confirmed as a bug. and removed needs-type Indicates an issue requires a type label. labels May 13, 2022
@nolouch
Copy link
Contributor

nolouch commented May 13, 2022

/check-issue-triage-complete

@nolouch
Copy link
Contributor

nolouch commented May 13, 2022

/check-issue-triage-complete

ti-chi-bot added a commit that referenced this issue May 16, 2022
close #4941

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue May 16, 2022
close tikv#4941

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue May 16, 2022
close tikv#4941

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this issue May 30, 2022
close #4941, ref #4942

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot added a commit that referenced this issue Jun 14, 2022
close #4941, ref #4942

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot added a commit that referenced this issue Jul 18, 2022
close #4941, ref #4942

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot added a commit that referenced this issue Sep 5, 2022
close #4941, ref #4942

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot added a commit that referenced this issue Sep 21, 2022
close #4941, ref #4942

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants