Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: speed scheduler exit #4148

Merged
merged 5 commits into from
Oct 12, 2021
Merged

cluster: speed scheduler exit #4148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ee33b4
speed schedule exit
bufferflies Sep 26, 2021
711ff85
add command
bufferflies Sep 26, 2021
658b084
Merge branch 'master' into feature/speedSchedule
bufferflies Sep 26, 2021
2e430c1
format annotation
bufferflies Oct 11, 2021
6b3b72b
Merge branch 'master' into feature/speedSchedule
bufferflies Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/cluster/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,8 @@ func (c *RaftCluster) Stop() {
}

c.running = false
close(c.quit)
c.coordinator.stop()
close(c.quit)
bufferflies marked this conversation as resolved.
Show resolved Hide resolved
c.Unlock()
c.wg.Wait()
log.Info("raftcluster is stopped")
Expand Down
6 changes: 6 additions & 0 deletions server/cluster/coordinator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,12 @@ func (s *scheduleController) Stop() {

func (s *scheduleController) Schedule() []*operator.Operator {
for i := 0; i < maxScheduleRetries; i++ {
// no need to retry if schedule should stop to speed exit
select {
bufferflies marked this conversation as resolved.
Show resolved Hide resolved
case <-s.ctx.Done():
return nil
default:
}
cacheCluster := opt.NewCacheCluster(s.cluster)
// If we have schedule, reset interval to the minimal interval.
if op := s.Scheduler.Schedule(cacheCluster); op != nil {
Expand Down