Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: speed scheduler exit #4148

Merged
merged 5 commits into from
Oct 12, 2021

Conversation

bufferflies
Copy link
Contributor

What problem does this PR solve?

closed #4146 speed schedule exit

What is changed and how it works?

pause scheduler after accept stop signal, and do not loop

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

speed scheduler exit  

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 24, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 24, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2021
@nolouch
Copy link
Contributor

nolouch commented Sep 26, 2021

the commit is strange.

Signed-off-by: bufferflies <1045931706@qq.com>
server/cluster/coordinator.go Outdated Show resolved Hide resolved
server/cluster/cluster.go Show resolved Hide resolved
@nolouch
Copy link
Contributor

nolouch commented Sep 26, 2021

/run-unit-test

@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #4148 (6b3b72b) into master (5e0c212) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4148      +/-   ##
==========================================
+ Coverage   74.70%   74.77%   +0.07%     
==========================================
  Files         260      260              
  Lines       26625    26629       +4     
==========================================
+ Hits        19889    19913      +24     
+ Misses       4950     4937      -13     
+ Partials     1786     1779       -7     
Flag Coverage Δ
unittests 74.77% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cluster/cluster.go 82.80% <100.00%> (+0.11%) ⬆️
server/cluster/coordinator.go 74.62% <100.00%> (+0.22%) ⬆️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/schedule/hbstream/heartbeat_streams.go 71.71% <0.00%> (-1.02%) ⬇️
server/server.go 71.40% <0.00%> (-0.45%) ⬇️
server/grpc_service.go 49.74% <0.00%> (-0.11%) ⬇️
server/tso/allocator_manager.go 65.16% <0.00%> (+0.16%) ⬆️
server/tso/tso.go 63.06% <0.00%> (+0.56%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0c212...6b3b72b. Read the comment docs.

@nolouch nolouch added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 labels Oct 9, 2021
Signed-off-by: bufferflies <1045931706@qq.com>
@nolouch
Copy link
Contributor

nolouch commented Oct 11, 2021

PTAL @rleungx

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2021
@nolouch
Copy link
Contributor

nolouch commented Oct 12, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6b3b72b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2021
@ti-chi-bot ti-chi-bot merged commit 49ba6b1 into tikv:master Oct 12, 2021
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Oct 12, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4198.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Oct 12, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4199.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Oct 12, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4200.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Oct 12, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4201.

ti-chi-bot added a commit that referenced this pull request Oct 13, 2021
* This is an automated cherry-pick of #4148

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* resolv conflict

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: buffer <1045931706@qq.com>
hzh0425 pushed a commit to hzh0425/pd that referenced this pull request Nov 16, 2021
* speed schedule exit

Signed-off-by: bufferflies <1045931706@qq.com>

* add command

Signed-off-by: bufferflies <1045931706@qq.com>

* format annotation

Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: hzh0425 <642256541@qq.com>
ti-chi-bot added a commit that referenced this pull request Nov 24, 2021
* This is an automated cherry-pick of #4148

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* resolv conflict

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: buffer <1045931706@qq.com>
nolouch pushed a commit that referenced this pull request Nov 30, 2021
* This is an automated cherry-pick of #4148

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
nolouch pushed a commit that referenced this pull request Nov 30, 2021
* This is an automated cherry-pick of #4148

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@bufferflies bufferflies deleted the feature/speedSchedule branch December 20, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schedule exit too slow when PD leader changed
4 participants