*: support WithReturnCommitTS and SetCommitWaitUntilTSO
#1831
Conversation
close tikv#1795 Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
txnkv: `Get` always return nil value when not found Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
ti-chi-bot
bot
added
dco-signoff: yes
lcwangchao
force-pushed
the
cp_commit_ts
branch
4 times, most recently
from
22baae7 to
41ab7c5
Compare
… option (tikv#1810) close pingcap/tidb#64797 Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>
lcwangchao
force-pushed
the
cp_commit_ts
branch
from
41ab7c5 to
8c71548
Compare
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
lcwangchao
force-pushed
the
cp_commit_ts
branch
from
6645293 to
c5bb4a0
Compare
ti-chi-bot
bot
added
needs-1-more-lgtm
|
@tiancaiamao PTAL |
| replace ( | ||
| github.com/go-ldap/ldap/v3 => github.com/YangKeao/ldap/v3 v3.4.5-0.20230421065457-369a3bab1117 | ||
| github.com/pingcap/tidb => github.com/lhy1024/tidb v1.1.0-beta.0.20251215110526-59e2c3c2eab3 | ||
| github.com/pingcap/tidb => github.com/lcwangchao/tidb v1.1.0-beta.0.20251229025756-9746aadede81 |
There was a problem hiding this comment.
So, client-go integration test is depending on fixed tidb commit, instead of latest?
There was a problem hiding this comment.
This dependency is only used for unistore. But we should rely on a personal branch to make sure this integration can be built because the master TiDB does not fit the API change.
|
@tiancaiamao: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, tiancaiamao, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com> Signed-off-by: tiancaiamao <tiancaiamao@gmail.com> Co-authored-by: tiancaiamao <tiancaiamao@gmail.com> Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com> Signed-off-by: tiancaiamao <tiancaiamao@gmail.com> Co-authored-by: tiancaiamao <tiancaiamao@gmail.com>
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com> Signed-off-by: tiancaiamao <tiancaiamao@gmail.com> Co-authored-by: tiancaiamao <tiancaiamao@gmail.com>
4 participants
This PR is a cherry-pick for:
*: return commit timestamp for Get / BatchGet if needed #1796
txnkv:
Getalways returnnilvalue when not found #1798txnkv: add SetCommitWaitUntilTSO and SetCommitWaitUntilTSOTimeout txn option #1810
It adds a new option
WithReturnCommitTSforGetandBatchGetto fetch the commit timestamp.It adds a new method
SetCommitWaitUntilTSOwhich indicates the txn should wait for the TSO after the specified timestamp to get a commit ts large enough.It adds a new method
SetCommitWaitUntilTSOTimeoutwhich indicates the timeout for waiting the TSO to be greater than the specifiy ts.