Skip to content

*: return commit timestamp for Get / BatchGet if needed #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 1 commit into from
Nov 17, 2025
Merged

*: return commit timestamp for Get / BatchGet if needed #1796

ti-chi-bot merged 1 commit into from
Nov 17, 2025

Conversation

@lcwangchao
Copy link
Contributor

@lcwangchao lcwangchao commented Nov 13, 2025

close #1795

  • introduce options for Get and BatchGet
  • introduce option WithRequireCommitTS to return commit timestamp
  • Get / BatchGet returns ValueEntry, which contains the CommitTS field

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. contribution This PR is from a community contributor. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 13, 2025
@lcwangchao lcwangchao mentioned this pull request Nov 13, 2025
Open
88 tasks
@lcwangchao
Copy link
Contributor Author

lcwangchao commented Nov 14, 2025

/ok-to-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 14, 2025

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Nov 14, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 14, 2025
@lcwangchao
Copy link
Contributor Author

lcwangchao commented Nov 14, 2025

/retest

cfzjywxk
cfzjywxk reviewed Nov 14, 2025
View reviewed changes
@lcwangchao
Copy link
Contributor Author

lcwangchao commented Nov 14, 2025

/test all

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 14, 2025

@lcwangchao: No presubmit jobs available for tikv/client-go@feature/active-active

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lcwangchao
Copy link
Contributor Author

lcwangchao commented Nov 14, 2025

/test ?

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 14, 2025

@lcwangchao: No presubmit jobs available for tikv/client-go@feature/active-active

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lcwangchao lcwangchao force-pushed the get_commit_ts branch 6 times, most recently from 073f0c1 to 29d51a5 Compare November 14, 2025 08:33
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 14, 2025
@lcwangchao lcwangchao force-pushed the get_commit_ts branch 2 times, most recently from 38447cf to 32bae9f Compare November 14, 2025 14:00
@lcwangchao
*: return commit timestamp for Get / BatchGet if needed
79e10a3 
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
@lcwangchao
Copy link
Contributor Author

lcwangchao commented Nov 14, 2025

/retest

4 similar comments
@lcwangchao
Copy link
Contributor Author

lcwangchao commented Nov 14, 2025

/retest

@lcwangchao
Copy link
Contributor Author

lcwangchao commented Nov 14, 2025

/retest

@lcwangchao
Copy link
Contributor Author

lcwangchao commented Nov 14, 2025

/retest

@lcwangchao
Copy link
Contributor Author

lcwangchao commented Nov 14, 2025

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 17, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-14 12:46:29.486258917 +0000 UTC m=+1051838.929288795: ☑️ agreed by cfzjywxk.
  • 2025-11-17 05:59:39.751198327 +0000 UTC m=+1286629.194228196: ☑️ agreed by zyguan.

@ti-chi-bot ti-chi-bot bot merged commit c75405d into tikv:feature/active-active Nov 17, 2025
34 of 42 checks passed
@lcwangchao lcwangchao deleted the get_commit_ts branch November 17, 2025 06:34
@lcwangchao lcwangchao mentioned this pull request Nov 18, 2025
Merged
lcwangchao added a commit to lcwangchao/client-go that referenced this pull request Dec 26, 2025
@lcwangchao
*: return commit timestamp for Get / BatchGet if needed (tikv#1796)
0da69fd 
close tikv#1795

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
@lcwangchao lcwangchao mentioned this pull request Dec 26, 2025
Merged
@lcwangchao lcwangchao mentioned this pull request Jan 26, 2026
Open
lcwangchao added a commit to lcwangchao/client-go that referenced this pull request Jan 26, 2026
@lcwangchao
*: return commit timestamp for Get / BatchGet if needed (tikv#1796)
671f516 
close tikv#1795

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@ekexium ekexium Awaiting requested review from ekexium

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

+1 more reviewer

@zyguan zyguan zyguan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lcwangchao @cfzjywxk @zyguan