Repository navigation
Conversation
Architect.init generated too much boilerplate for small teams and documented obvious decisions. This adds team-size awareness (auto-detected from git history) to calibrate output depth, a surprise-value heuristic to skip trivial ADRs, and a risks/gaps analysis phase as the primary valuable output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Template references were hardcoded to .specify/templates/ which doesn't exist in release packages. Use a relative path from the script directory instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
@alfasin fixed using another methods, upload latest version |
Author
|
Done |
Member
|
Sorry, I mean I already took your concepts into the main branch in a differ way, try to use the latest version to see the changes |
Author
|
closing because the product that was generated was not as good. |
kanfil
added a commit
that referenced
this pull request
Jul 27, 2026
Address Copilot review findings that left generated event hooks inert or schema-invalid after the rework: - #2: the resolved events map now carries an ordered list of handlers per event (dict[str, list[dict]]) so two extensions declaring the same event both run instead of the last one silently winning. collect_extension_events accumulates; every adapter emits one native entry per handler. - #6: Claude/Gemini/Qwen/Devin/Tabnine native schema accepts a single 'command' string, not command+args. Each adapter now renders one complete shell invocation of the dispatcher via _dispatcher_command(). - #7: Gemini measures hook timeouts in milliseconds; add events_timeout_unit attr and _native_timeout() so the 60s default becomes 60000ms instead of terminating the dispatcher after 60ms. - #4: _resolve_event_command_argv() replaces _extract_script_path() — scripts: values are command strings (e.g. 'scripts/bash/setup-plan.sh --json'), not bare paths. Resolves the project's sh/ps/py variant, splits safely into argv, and prepends the interpreter for .py. - #5: bundled-template fallback now uses _locate_core_pack()/_repo_root() (core_pack/commands, not the non-existent core_pack/templates/commands). - #16: all formatters use IntegrationBase.resolve_python_interpreter() so generated commands honor the project venv and never hard-code python3 (absent on Windows). The opencode TS plugin bakes in the same resolved interpreter. - #13: opencode TS plugin runEvent() now throws on failure instead of process.exit(2), which killed the OpenCode host process; only the failing hook is rejected. - #21: user YAML override is validated (event names, non-empty command strings) before returning; a malformed override is warned about and ignored rather than crashing installation on cfg.get(). Bump dev version 0.14.2.dev1 -> 0.14.2.dev2 (gemini/__init__.py change) and add a CHANGELOG entry. Refs: PR github#3704 Copilot inline review (findings #2, #4, #5, #6, #7, #13, #16, #21) Assisted-by: opencode (model: glm-5.2, autonomous)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--team-sizeoverride) to scale output depth — small teams get lean templates and fewer ADRs, large teams get full Rozanski & WoodsAD-template-lean.mdfor small/medium teamsTest plan
setup-architecture.sh initon a solo-dev repo — should auto-detect "small" tier and use lean templatesetup-architecture.sh init --team-size large— should use full template/architect.initon a brownfield codebase — verify ADRs only cover surprising decisions--team-sizeflag parsing works with both--team-size=smalland--team-size smallforms🤖 Generated with Claude Code