Render resources specified in the EGW CR#4427
Merged
sridhartigera merged 3 commits intotigera:masterfrom Feb 12, 2026
Merged
Conversation
caseydavenport
requested changes
Feb 11, 2026
| } | ||
|
|
||
| func (c *component) getResources() corev1.ResourceRequirements { | ||
| resourceRequirements := corev1.ResourceRequirements{ |
Member
There was a problem hiding this comment.
I don't think we should need to do this explicitly here. We have an "Overrides" mechanism that is meant to handle this automatically -
operator/pkg/render/egressgateway/egressgateway.go
Lines 154 to 156 in c3cb855
| rcomp.ApplyDeploymentOverrides(&d, overrides) | ||
| } | ||
|
|
||
| c.addAWSResources(&d) |
Member
There was a problem hiding this comment.
Worth a comment explaining we do this here after applying overrides to ensure they don't get overwritten if a user provides their own values.
caseydavenport
approved these changes
Feb 12, 2026
Member
caseydavenport
left a comment
caseydavenport
left a comment
There was a problem hiding this comment.
One minor comment about a comment, but otherwise LGTM
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resource limits and requests specified in the EGW custom resource must be rendered in the EGW deployment.
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.