Skip to content

Conversation

robomic
Copy link
Contributor

@robomic robomic commented Jun 17, 2024

Description

Abstract

This PR contains unit tests for multiple classes, all of them are a part of traffic_simulator package.

Details

Since classes tested here did not need numerous test cases, it was decided to include them in a singular PR.
List of tests included in this PR:

  1. TrafficLight.Color_make
  2. TrafficLight.Shape_make
  3. TrafficLight.Status_make
  4. TrafficLight.Bulb_make
  5. TrafficLight.Bulb_trafficLightMessageConversion
  6. TrafficLight.Color_make_wrong
  7. TrafficLight.Shape_make_wrong
  8. TrafficLight.Status_make_wrong
  9. TrafficLight.Bulb_make_wrong
  10. Behavior.getRequestString
  11. RoutePlanner.getGoalPoses
  12. RoutePlanner.getGoalPosesInWorldFrame
  13. RoutePlanner.getRouteLanelets_horizon
  14. RoutePlanner.getRouteLanelets_noHorizon
  15. RoutePlanner.getRouteLanelets_empty
  16. Job.onUpdate
  17. JobList.append
  18. JobList.append_doubled
  19. JobList.update
  20. SimulationClock.Initialize
  21. SimulationClock.getCurrentRosTime
  22. SimulationClock.getCurrentScenarioTime
  23. SimulationClock.Update

References

Jira ticket: internal link

Destructive Changes

There are no destructive changes.

Copy link

github-actions bot commented Jun 17, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@robomic robomic marked this pull request as ready for review June 17, 2024 16:44
@robomic robomic self-assigned this Jun 18, 2024
@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Jun 24, 2024
@hakuturu583 hakuturu583 merged commit b209600 into master Jun 24, 2024
@hakuturu583 hakuturu583 deleted the feature/unit_tests/miscellaneous branch June 24, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants