forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity): support new traffic signal interface #683
Merged
tkimura4
merged 15 commits into
beta/v0.10.0
from
feat/support-new-traffic-signal-interface_v0.10.0
Jul 25, 2023
Merged
feat(behavior_velocity): support new traffic signal interface #683
tkimura4
merged 15 commits into
beta/v0.10.0
from
feat/support-new-traffic-signal-interface_v0.10.0
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Resolved conflicts in planning/behavior_velocity_planner_common/package.xml Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Resolved conflicts in `scene_crosswalk.cpp` Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…face' into feat/support-new-traffic-signal-interface_v0.10.0
tkimura4
requested review from
kyoichi-sugahara,
TakaHoribe,
taikitanaka3,
satoshi-ota,
shmpwk,
isamu-takagi,
kosuke55,
mkuri,
soblin,
maxime-clem,
takayuki5168,
TomohitoAndo,
purewater0901,
rej55 and
zulfaqar-azmi-t4
as code owners
July 25, 2023 08:35
tkimura4
removed request for
rej55,
TomohitoAndo,
takayuki5168,
TakaHoribe,
kyoichi-sugahara,
kosuke55,
purewater0901,
isamu-takagi,
satoshi-ota,
taikitanaka3,
maxime-clem and
zulfaqar-azmi-t4
July 25, 2023 08:35
github-actions
bot
added
documentation
Improvements or additions to documentation
launch
planning
common
labels
Jul 25, 2023
tkimura4
requested review from
Naophis and
1222-takeshi
and removed request for
mkuri and
soblin
July 25, 2023 08:35
1222-takeshi
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
autowarefoundation#4133
Hotfix to beta/v0.10.0
Related links
#677
Tests performed
Tested on a simple planning simulator.
Notes for reviewers
Interface changes
Effects on system behavior
no effects
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.