Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity): support new traffic signal interface #683

Merged

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Jul 25, 2023

Description

autowarefoundation#4133
Hotfix to beta/v0.10.0

In this Pull Request, we are introducing support for the new traffic signal messages within the planning modules.
For more detailed information about the new messages, please refer to the associated issue linked below.
autowarefoundation#2567

Related links

#677

Tests performed

Tested on a simple planning simulator.

Notes for reviewers

For the traffic light module, I have removed the old messages and variables previously used to manage inputs from either Perception or External sources, given that the External input is no longer used.
Moreover, since the input Traffic Signal message, processed by traffic_signal_arbiter, already contains the selected data (either the signal with the highest confidence or the input from the V2X source), I have also removed the process to find the signal with the highest confidence.

Interface changes

As mentioned above, Planning modules will support only new interface.
The interface change for perception modules was done in this PR.
autowarefoundation#4084

Effects on system behavior

no effects

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

TomohitoAndo and others added 15 commits June 30, 2023 22:33
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Resolved conflicts in planning/behavior_velocity_planner_common/package.xml

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Resolved conflicts in `scene_crosswalk.cpp`

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…face' into feat/support-new-traffic-signal-interface_v0.10.0
Copy link

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4
Copy link
Collaborator Author

image

Rvizと型的につながっていることを確認.

@tkimura4 tkimura4 merged commit f30df97 into beta/v0.10.0 Jul 25, 2023
@tkimura4 tkimura4 deleted the feat/support-new-traffic-signal-interface_v0.10.0 branch July 25, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common documentation Improvements or additions to documentation launch planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants