Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): fix lane change force approval by rtc (#2672) #246

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Jan 17, 2023

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Description

autowarefoundation#2672
Hotfix to beta/v0.7.0

Related links

autowarefoundation#2672

Tests performed

See autowarefoundation#2672

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…dation#2672)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 marked this pull request as ready for review January 17, 2023 12:19
@tkimura4 tkimura4 marked this pull request as draft January 17, 2023 12:19
@tkimura4 tkimura4 marked this pull request as ready for review January 17, 2023 12:19
@tkimura4 tkimura4 changed the title fix(lane_change): fix lane change force approval by rtc (autowarefoundation#2672) fix(lane_change): fix lane change force approval by rtc (#2672) Jan 17, 2023
@tkimura4 tkimura4 requested review from kosuke55 and 1222-takeshi and removed request for kosuke55 and shmpwk January 17, 2023 12:52
@tkimura4 tkimura4 enabled auto-merge (squash) January 17, 2023 12:56
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.7.0@cebd7cc). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             beta/v0.7.0    #246   +/-   ##
=============================================
  Coverage               ?   3.08%           
=============================================
  Files                  ?      68           
  Lines                  ?    8001           
  Branches               ?    3839           
=============================================
  Hits                   ?     247           
  Misses                 ?    7542           
  Partials               ?     212           
Flag Coverage Δ
differential 3.08% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit b9fce1f into beta/v0.7.0 Jan 17, 2023
@tkimura4 tkimura4 deleted the fix/lane_change_force_approval_v0.7.0 branch January 17, 2023 14:15
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
* ci: add setup-universe.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add -v

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* use -vvv

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix style

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* upgrade pyOpenSSL

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants