Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_lidar_transfusion): autoware transfusion changes cherry pick #1586

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

SamratThapa120
Copy link

@SamratThapa120 SamratThapa120 commented Oct 11, 2024

Description

Cherry pick following 2 PRs

autowarefoundation#9057
autowarefoundation#9052

Related links

Parent Issue:

  • Link

How was this PR tested?

https://evaluation.tier4.jp/evaluation/reports/2b37e1da-6e28-5c31-b729-daf50689c7ca?project_id=prd_jt
Tested using webauto evaluator. Only once test fails, because the lidar does not include intensity field in it, and transfusion requires intensity value to function properly

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

SamratThapa120 and others added 2 commits October 10, 2024 15:32
…towarefoundation#9052)

* fix bbox orientation

Signed-off-by: Samrat Thapa <samratthapa120@gmail.com>

* revert newline changes

Signed-off-by: Samrat Thapa <samratthapa120@gmail.com>

* change kernel

Signed-off-by: Samrat Thapa <samratthapa120@gmail.com>

---------

Signed-off-by: Samrat Thapa <samratthapa120@gmail.com>
Co-authored-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
…edefined values. (autowarefoundation#9057)

* set tensor order using api

Signed-off-by: Samrat Thapa <samratthapa120@gmail.com>

* style(pre-commit): autofix

Signed-off-by: Samrat Thapa <samratthapa120@gmail.com>

* fix tensor order

Signed-off-by: Samrat Thapa <samratthapa120@gmail.com>

* style(pre-commit): autofix

Signed-off-by: Samrat Thapa <samratthapa120@gmail.com>

* style fix

Signed-off-by: Samrat Thapa <samratthapa120@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: Samrat Thapa <samratthapa120@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@SamratThapa120 SamratThapa120 marked this pull request as ready for review October 11, 2024 03:08
@SamratThapa120 SamratThapa120 requested a review from shmpwk October 11, 2024 03:08
Copy link

Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@shmpwk shmpwk merged commit a8719a9 into beta/v0.36 Oct 11, 2024
19 of 20 checks passed
@shmpwk shmpwk deleted the fix/beta/v0.36/transfusion branch October 11, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants