-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(words): add 'localtime' #786
feat(words): add 'localtime' #786
Conversation
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Please provide a link to prove the word exists, as other developers have done? |
"Logiee" is already in the dictionary, so why do we need to add an "logiee-ss"? |
@HansRobo Thank you so much for your review! Let me answer 👍
Here the
Oh, this is my misunderstanding! Yes, you are right, |
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
@HansRobo Fixed by this commit 👍 . I do not see a |
@sasakisasaki
Sorry, my explanation was confusing. Normally, "localtime" is a compound word consisting of "local" and "time" and should be used with clear word separation such as "local time" or "LocalTime" or "local_time" and should not be added to the dictionary. If you still must add it, you must give a reason why, and the fact that you are using it or that it is causing you errors is not a reason. All you need to do here is provide a reliable source of information like https://linux.die.net/man/3/localtime that explains the fact that in the context of Linux and C, the compound word "localtime" is commonly used without any separators. This has become a long message, but it would be very helpful if you could pay attention to these things next time. You can read my point here too: https://github.com/tier4/autoware-spell-check-dict/blob/main/CONTRIBUTING.md |
FYI, when you want to add a word, you can use a useful workflow. |
@HansRobo Thanks, that really makes sense.
I got it and I have read the guideline for contribution 👍
Oh! This is so useful! Thank you very much @HansRobo ! |
As the title indicates 👍