feat(overrides): ignore (max|min)(xyz) in .xml #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shmpwk Could you look at other PRs and explain what each word means? 🙇 |
4 tasks
kenji-miyake
changed the title
|
Also, you can consider ignoring words in README files. |
|
Thank you for your review. |
shmpwk
changed the title
| @@ -136,6 +136,7 @@ | |||
| { | |||
| "filename": "**/{*.cpp,*.hpp,*.py,*.sh,*.xml,*.yaml,CMakeLists.txt}", | |||
| "ignoreRegExpList": [ | |||
| "(max|min)(xyz)", | |||
There was a problem hiding this comment.
It's a good solution, but I think we have to encourage people to replace minx with min_x.
So I'm sorry, but could you close this PR and leave the min/max typos as they are? 🙏
|
Close by #280 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add unknown words below:
https://github.com/autowarefoundation/autoware.universe/runs/6571869093?check_suite_focus=true