Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add COLCON_IGNORE #15

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

yabuta
Copy link
Collaborator

@yabuta yabuta commented Jul 19, 2022

Description

There is build error in stop_accel_evaluator.
So I add COLCON_IGNORE to stop_accel_evaluator folder.

Related links

Tests performed

  • build goes well.
    • colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release

Notes for reviewers

Please fix this build error.

--- stderr: stop_accel_evaluator                                  
In file included from /usr/include/x86_64-linux-gnu/c++/9/bits/c++allocator.h:33,
                 from /usr/include/c++/9/bits/allocator.h:46,
                 from /usr/include/c++/9/string:41,
                 from /usr/include/c++/9/stdexcept:39,
                 from /usr/include/c++/9/array:39,
                 from /usr/include/c++/9/tuple:39,
                 from /usr/include/c++/9/functional:54,
                 from /usr/include/c++/9/pstl/glue_algorithm_defs.h:13,
                 from /usr/include/c++/9/algorithm:71,
                 from /home/makotoyabuta/workspace/autoware.proj/src/autoware/calibration_tools/control/stop_accel_evaluator/src/stop_accel_evaluator_node.cpp:15:
/usr/include/c++/9/ext/new_allocator.h: In instantiation of ‘void __gnu_cxx::new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up = LowpassFilter1d; _Args = {double, double}; _Tp = LowpassFilter1d]’:
/usr/include/c++/9/bits/alloc_traits.h:483:4:   required from ‘static void std::allocator_traits<std::allocator<_Tp> >::construct(std::allocator_traits<std::allocator<_Tp> >::allocator_type&, _Up*, _Args&& ...) [with _Up = LowpassFilter1d; _Args = {double, double}; _Tp = LowpassFilter1d; std::allocator_traits<std::allocator<_Tp> >::allocator_type = std::allocator<LowpassFilter1d>]’
/usr/include/c++/9/bits/shared_ptr_base.h:548:39:   required from ‘std::_Sp_counted_ptr_inplace<_Tp, _Alloc, _Lp>::_Sp_counted_ptr_inplace(_Alloc, _Args&& ...) [with _Args = {double, double}; _Tp = LowpassFilter1d; _Alloc = std::allocator<LowpassFilter1d>; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’
/usr/include/c++/9/bits/shared_ptr_base.h:679:16:   required from ‘std::__shared_count<_Lp>::__shared_count(_Tp*&, std::_Sp_alloc_shared_tag<_Alloc>, _Args&& ...) [with _Tp = LowpassFilter1d; _Alloc = std::allocator<LowpassFilter1d>; _Args = {double, double}; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’
/usr/include/c++/9/bits/shared_ptr_base.h:1344:71:   required from ‘std::__shared_ptr<_Tp, _Lp>::__shared_ptr(std::_Sp_alloc_shared_tag<_Tp>, _Args&& ...) [with _Alloc = std::allocator<LowpassFilter1d>; _Args = {double, double}; _Tp = LowpassFilter1d; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’
/usr/include/c++/9/bits/shared_ptr.h:359:59:   required from ‘std::shared_ptr<_Tp>::shared_ptr(std::_Sp_alloc_shared_tag<_Tp>, _Args&& ...) [with _Alloc = std::allocator<LowpassFilter1d>; _Args = {double, double}; _Tp = LowpassFilter1d]’
/usr/include/c++/9/bits/shared_ptr.h:701:14:   required from ‘std::shared_ptr<_Tp> std::allocate_shared(const _Alloc&, _Args&& ...) [with _Tp = LowpassFilter1d; _Alloc = std::allocator<LowpassFilter1d>; _Args = {double, double}]’
/usr/include/c++/9/bits/shared_ptr.h:717:39:   required from ‘std::shared_ptr<_Tp> std::make_shared(_Args&& ...) [with _Tp = LowpassFilter1d; _Args = {double, double}]’
/home/makotoyabuta/workspace/autoware.proj/src/autoware/calibration_tools/control/stop_accel_evaluator/src/stop_accel_evaluator_node.cpp:48:104:   required from here
/usr/include/c++/9/ext/new_allocator.h:146:4: error: no matching function for call to ‘LowpassFilter1d::LowpassFilter1d(double, double)’
  146 |  { ::new((void *)__p) _Up(std::forward<_Args>(__args)...); }
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/makotoyabuta/workspace/autoware.proj/src/autoware/calibration_tools/control/stop_accel_evaluator/include/stop_accel_evaluator/stop_accel_evaluator_node.hpp:28,
                 from /home/makotoyabuta/workspace/autoware.proj/src/autoware/calibration_tools/control/stop_accel_evaluator/src/stop_accel_evaluator_node.cpp:21:
/home/makotoyabuta/workspace/autoware.proj/install/signal_processing/include/signal_processing/lowpass_filter_1d.hpp:31:12: note: candidate: ‘LowpassFilter1d::LowpassFilter1d(double)’
   31 |   explicit LowpassFilter1d(const double gain);
      |            ^~~~~~~~~~~~~~~
/home/makotoyabuta/workspace/autoware.proj/install/signal_processing/include/signal_processing/lowpass_filter_1d.hpp:31:12: note:   candidate expects 1 argument, 2 provided
/home/makotoyabuta/workspace/autoware.proj/install/signal_processing/include/signal_processing/lowpass_filter_1d.hpp:24:7: note: candidate: ‘constexpr LowpassFilter1d::LowpassFilter1d(const LowpassFilter1d&)’
   24 | class LowpassFilter1d
      |       ^~~~~~~~~~~~~~~
/home/makotoyabuta/workspace/autoware.proj/install/signal_processing/include/signal_processing/lowpass_filter_1d.hpp:24:7: note:   candidate expects 1 argument, 2 provided
/home/makotoyabuta/workspace/autoware.proj/install/signal_processing/include/signal_processing/lowpass_filter_1d.hpp:24:7: note: candidate: ‘constexpr LowpassFilter1d::LowpassFilter1d(LowpassFilter1d&&)’
/home/makotoyabuta/workspace/autoware.proj/install/signal_processing/include/signal_processing/lowpass_filter_1d.hpp:24:7: note:   candidate expects 1 argument, 2 provided
make[2]: *** [CMakeFiles/stop_accel_evaluator_node.dir/build.make:63: CMakeFiles/stop_accel_evaluator_node.dir/src/stop_accel_evaluator_node.cpp.o] エラー 1
make[1]: *** [CMakeFiles/Makefile2:134: CMakeFiles/stop_accel_evaluator_node.dir/all] エラー 2
make: *** [Makefile:141: all] エラー 2
---
Failed   <<< stop_accel_evaluator [7.68s, exited with code 2]

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yabuta yabuta requested a review from takayuki5168 July 19, 2022 01:45
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yabuta yabuta merged commit 3863d4b into tier4/universe Jul 19, 2022
@yabuta yabuta deleted the feature/temp_ignore_stop_accel_evalator branch September 9, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants