Update to ReadStat 1.1.9 #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintains iconv hack from c1f9f19 and solaris hack from 4a878a1. * Fix various SAS catalog file reading bugs (fix #529, fix #653, fix #680, fix #696, fix #705). * Increase maximum SAS page file size to 16MB (fix #697). * Ignore invalid SAV timestamp strings (fix #683). * Fix compiler warnings (fix #707).
|
I need to get a release to CRAN by the 26th; do you think we can make that work? |
|
Yeah that should work - the ReadStat update fixes the compiler warnings in R-devel. There are a couple of other little things I'd like to do before the next release that I can sort out tomorrow. |
|
@gorcha thanks, it's much appreciated 😄 |
|
No worries at all! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update includes a heap of bug fixes:
catalog_fileignored inread_sas()when file created on Unix system #696, fixhaven::read_sas()unable to allocate memory for <16MB SAS page sizes #705).Includes the ReadStat hacks: