Fixing write_dta labels checking, addressing #606 #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
Jul 25, 2021
There was a problem hiding this comment.
Thanks! Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).
|
Thanks @jmobrien — btw if you use "fixes" or "closes" instead of "addresses", GitHub will automatically close the associated issue when the PR is merged. |
|
Glad to help. And thanks for the useful tip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #606.
Added an initial check for missing labels in
has_non_integer_labels(). Previously,as_integerish()was returning FALSE when labels were missing.Also, associated test was missing an apparently-intended line that would have caught this. Test passes now.