Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use old-style SPSS compression by default for .sav (SPSS) files, sinc… #544

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

oliverbock
Copy link
Contributor

…e almost nobody uses the inefficient uncompressed format. The newer ZCompressed format (compress=TRUE) is even better, but is much less used and less supported by third-party tools.

@hadley
Copy link
Member

hadley commented Apr 8, 2021

Could you please update the documentation for write_sav() and add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

@oliverbock oliverbock force-pushed the master branch 2 times, most recently from a2bc55d to 37511b4 Compare April 8, 2021 22:13
@@ -91,7 +91,7 @@ to enforce them.}
\item{path}{Path to a file where the data will be written.}

\item{compress}{If \code{TRUE}, will compress the file, resulting in a \code{.zsav}
file.}
file. Otherwise the \code{.sav} file will be bytecode compressed.}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to edit the underlying roxygen2 docs next to the definition of read_spss()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it. Thanks.

…e almost nobody uses the inefficient uncompressed format. The newer ZCompressed format (compress=TRUE) is even better, but is much less used and less supported by third-party tools.
@hadley hadley merged commit 3130d51 into tidyverse:master Apr 9, 2021
@hadley
Copy link
Member

hadley commented Apr 9, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants