Separate write tests for sav and dta #140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two formats are different enough that they need to be tested separately. Even if the code paths in haven are similar, some sav features such as labelled character variables are not supported by the dta format. Applying the same tests to write_dta reveals two bugs in the handling of labelleds.
This was referenced Dec 4, 2015
|
Superseded by #145. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two formats are different enough that they need to be tested
separately. Even if the code paths in haven are similar, some sav
features such as labelled character variables are not supported by the
dta format.
Applying the same tests to write_dta reveals two bugs in the handling of
labelleds.