max_level_lengths can't deal with missings in levels

[rubenarslan]

If there is an NA in a factor level, haven will fail to write because of the following error.

x = data.frame(x = factor(c(1, 2, 3, NA), exclude = NULL))
haven::write_sav(x, path = tempfile())
#> Error in if (any(bad_lengths)) {: missing value where TRUE/FALSE needed

I this can easily be fixed by changing

max(nchar(levels(x))) to
max(nchar(levels(x)), na.rm = TRUE)

in haven:::max_level_lengths

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/