Skip to content

Add position_jitterdodge #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2014
Merged

Add position_jitterdodge #932

merged 2 commits into from
Mar 25, 2014

Conversation

kevinushey
Copy link
Contributor

Hi Hadley,

See some of my comments inline -- I need your input to tidy things up.

#' Jitter-dodge points to align them with a boxplot including fill aesthetic
#'
#' @family position adjustments
#' @param width degree of jitter in x direction. Defaults to 40\% of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document both in one line: @param width, height .... Would eliminate some duplication

@hadley
Copy link
Member

hadley commented Mar 13, 2014

  • Motivate the change in one paragraph, and include it in NEWS.
    In parentheses, reference your github user name and this issue:
    (@hadley, #1234)
  • Check pull request only includes relevant changes.
  • Use the official style.
  • Update documentation and re-run roxygen2
  • Add minimal example, if new graphical feature

@hadley
Copy link
Member

hadley commented Mar 13, 2014

Worth reviewing interaction with #927

  * Motivate the change in NEWS
  * Fix the style
  * Allow jitter.width, jitter.height, dodge.width as arguments
  * Improve the documentation
@hadley hadley merged commit 9b5bb8b into tidyverse:master Mar 25, 2014
@hadley
Copy link
Member

hadley commented Mar 25, 2014

Thanks!

@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants