Skip to content

Add parameter "varwidth" to geom_boxplot #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2014

Conversation

tsieger
Copy link

@tsieger tsieger commented Feb 27, 2014

Resubmitting #900 (after rebasing against master and re-documenting with the development
version of roxygen2 (4.0.0)).

Summary: stat-boxplot and geom-boxplot enriched in order to enable displaying boxplots of width proportional to the square root of the number of observations, possibly weighted.

#' @param varwidth if \code{FALSE} (default) make a standard box plot. If
#' \code{TRUE}, boxes are drawn with widths proportional to the
#' square-roots of the number of observations in the groups (possibly
#' weighted).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify to mention weight aesthetic?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hadley
Copy link
Member

hadley commented Mar 13, 2014

  • Motivate the change in one paragraph, and include it in NEWS.
    In parentheses, reference your github user name and this issue:
    (@hadley, #1234)
  • Check pull request only includes relevant changes.
  • Use the official style.
  • Update documentation and re-run roxygen2
  • Add minimal example, if new graphical feature

@hadley hadley mentioned this pull request Mar 13, 2014
@hadley
Copy link
Member

hadley commented Mar 25, 2014

If you can make the suggested changes this week, you contribution will make it into the next version of ggplot2.

@tsieger
Copy link
Author

tsieger commented Mar 25, 2014

Thanks!
Hopefully, I addressed all your suggestions.

@hadley hadley merged commit 5dc188a into tidyverse:master Mar 26, 2014
@hadley
Copy link
Member

hadley commented Mar 26, 2014

Thanks, it's now in.

@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants