-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Allow to reverse the order of colours in a brewer palette #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I kept the pull-request separated but I am not sure how this one will interact with #925. Please pull the other first, because it is larger. I will rebase this one if necessary. |
The CI fails because it requires an updated version of scales which has the direction argument in brewer_pal |
NB: an example in #925 uses this functionality. It won't fail but the output would be the same. This does not have to be pulled first but it would be best to pull the two together. |
EDIT later today: actually it's using |
Use the same argument that scale_*_hue uses: direction
Rebased on master and acknowledge the existence of |
Forgot the NEWS, now it's ready to be pulled ;) |
I might keep this on the shelf for now, because I'd rather not have to also release scales. |
Any chance of including this here and in scales, now that a new version of ggplot2 is out, so that it would make it with the next version of ggplot2 + scales? Most diverging palettes of colorbrewer as useless without it because they associate warm colours to low numbers. Thanks in advance. |
Can you please merge/rebase? If it still needs the dev version of scales, can you please update the DESCRIPTION? |
Ideally, I would need you to pull #1076 first. Then I'll rebase (or more probably just completely rewrite) this on top of it. The changes in Do you plan on releasing scales also? |
I'm planning on releasing scales tomorrow. |
Can you please finish this off now that scales is out? You'll need to add an explicit version requirement in the DESCRIPTION |
#1139 replaces this one (much simpler thanks to the change in scales and branches from a recent master) |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Use the same argument that scale_*_hue uses: direction