Skip to content

Allow to reverse the order of colours in a brewer palette #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

jiho
Copy link
Contributor

@jiho jiho commented Feb 27, 2014

Use the same argument that scale_*_hue uses: direction

@jiho
Copy link
Contributor Author

jiho commented Feb 27, 2014

I kept the pull-request separated but I am not sure how this one will interact with #925. Please pull the other first, because it is larger. I will rebase this one if necessary.

@jiho
Copy link
Contributor Author

jiho commented Feb 27, 2014

The CI fails because it requires an updated version of scales which has the direction argument in brewer_pal

@jiho
Copy link
Contributor Author

jiho commented Mar 17, 2014

NB: an example in #925 uses this functionality. It won't fail but the output would be the same. This does not have to be pulled first but it would be best to pull the two together.

@jiho
Copy link
Contributor Author

jiho commented Mar 17, 2014

EDIT later today: actually it's using trans = "reverse", not direction so it's fine. Still the two are touching the same file and will surely conflict. Pull one and I'll rebase the other afterwards. This one is simpler so I would pull #925 first and I'll rebase this one afterwards (I'll probably alter the example to use direction too).

@jiho
Copy link
Contributor Author

jiho commented Mar 21, 2014

Rebased on master and acknowledge the existence of scale_*_distiller now. Should be ready to pull (but the corresponding PR in scales r-lib/scales#36 should be pulled simultaneously).

@jiho
Copy link
Contributor Author

jiho commented Mar 21, 2014

Forgot the NEWS, now it's ready to be pulled ;)

@hadley
Copy link
Member

hadley commented Mar 21, 2014

I might keep this on the shelf for now, because I'd rather not have to also release scales.

@hadley hadley added the on hold label Mar 26, 2014
@jiho
Copy link
Contributor Author

jiho commented Jun 17, 2014

Any chance of including this here and in scales, now that a new version of ggplot2 is out, so that it would make it with the next version of ggplot2 + scales? Most diverging palettes of colorbrewer as useless without it because they associate warm colours to low numbers.

Thanks in advance.

@hadley
Copy link
Member

hadley commented Jun 11, 2015

Can you please merge/rebase? If it still needs the dev version of scales, can you please update the DESCRIPTION?

@jiho
Copy link
Contributor Author

jiho commented Jun 11, 2015

Ideally, I would need you to pull #1076 first. Then I'll rebase (or more probably just completely rewrite) this on top of it. The changes in scales are minimal (r-lib/scales#36) but should be released in order for this to not depend on a dev version of scales, which is probably unsuitable.

Do you plan on releasing scales also?

@hadley
Copy link
Member

hadley commented Jun 11, 2015

I'm planning on releasing scales tomorrow.

@hadley
Copy link
Member

hadley commented Jun 18, 2015

Can you please finish this off now that scales is out? You'll need to add an explicit version requirement in the DESCRIPTION

@jiho
Copy link
Contributor Author

jiho commented Jun 18, 2015

#1139 replaces this one (much simpler thanks to the change in scales and branches from a recent master)

@jiho jiho closed this Jun 18, 2015
@jiho jiho deleted the feature/reverse_brewer branch June 18, 2015 19:58
@lock
Copy link

lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants