Improvements to scale_*_distiller #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realised that I already submitted the colourbar aspect as another pull-request #1017. Let me know how you want to handle those. |
|
Could you please merge/rebase so that it builds on travis? Otherwise looks good. |
Sequential brewer palettes (which are the most appropriate for continuous interpolation by scale_*_distiller) are presented from dark to light luminance on the colorbrewer website but created from light to dark by brewer.pal. Similarly, some diverging palettes have some sort of intuitive order which is not inverted by the combination of brewer.pal and continuous_scale Reversing the colours gives the expected result: - light for higher values - blue for low values, red for high values.
jiho
force-pushed
the
fix/scale_distiller
branch
from
31d7a40 to
6a6db4a
Compare
hadley
added a commit
that referenced
this pull request
Jun 12, 2015
Improvements to scale_*_distiller
|
Thanks! |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of colors in particular, and the fact that it cannot be easily
reversed (pending a change in package scales) makes scale_*_distiller
almost useless at the moment.
These are simple fixes and should be easy to pull.