Skip to content

Apply the same fix as #4667 to draw_key_point() #4938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Aug 10, 2022

Address #4667 (comment)

devtools::load_all("~/GitHub/ggplot2/")
#> ℹ Loading ggplot2
ggplot(mtcars, aes(wt, mpg)) + geom_point(aes(size = qsec), alpha = .5, stroke = NA)

Created on 2022-08-11 by the reprex package (v2.0.1)

@ZhangSR-kolar
Copy link

Thank you very much for the improvement! May I ask how can I apply it by myself as a general user? (for it hasn't been merged into the main of ggplot2).

@yutannihilation
Copy link
Member Author

If you want to test this, you can install by install_github.

devtools::install_github("tidyverse/ggplot2#4938")

@ZhangSR-kolar
Copy link

If you want to test this, you can install by install_github.

devtools::install_github("tidyverse/ggplot2#4938")

ok. Thank you very much~

@yutannihilation yutannihilation merged commit 1c20c94 into tidyverse:main Aug 23, 2022
@yutannihilation yutannihilation deleted the issue-4624-na-stroke-legend branch August 23, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants