Don't allow stroke = NA to mess up point sizing #4667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauswilke
approved these changes
Nov 11, 2021
|
Hi, thanks for the improvement of the 'stroke' vs. 'size' issue. However, when I use the development version of ggplot2, though 'stroke = NA' won't change the 'size' aes in the plot region, the size legend was still marked and showed with the same size. |
|
Oh, good catch! Thanks. |
yutannihilation
added a commit
to yutannihilation/ggplot2
that referenced
this pull request
Aug 10, 2022
yutannihilation
added a commit
that referenced
this pull request
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4624 by treating ´NA
as0` when calculating point size