Skip to content

Pass dots to continuous_scale in scale_size/radius #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DarwinAwardWinner
Copy link
Contributor

I tried to pass na.value to scale_size_continuous, and was surprised when it threw an error instead of passing it along to continuous_scale. This pull request fixes that by having it pass along ....

@has2k1
Copy link
Contributor

has2k1 commented Aug 29, 2016

Some refactoring of the code base a while ago got rid of ... from some of the user facing API. I think it was aiming for a more explicit documentation. So, if you are adding ..., you should add an item in the documentation of where those other parameters are defined.

@DarwinAwardWinner
Copy link
Contributor Author

Would it be sufficient to add the following passage from other continuous scales (e.g. scale_alpha_continuous)?

 ...: Other arguments passed on to 'continuous_scale' or
      'discrete_scale' as appropriate, to control name, limits,
      breaks, labels and so forth.

@has2k1
Copy link
Contributor

has2k1 commented Aug 30, 2016

That should do.

@hadley
Copy link
Member

hadley commented Aug 30, 2016

I'd much rather you passed along specific arguments so that the document for individual scales remains self contained.

@lock
Copy link

lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants