Pass dots to continuous_scale in scale_size/radius#1735
Closed
DarwinAwardWinner wants to merge 1 commit intotidyverse:masterfrom
Closed
Pass dots to continuous_scale in scale_size/radius#1735DarwinAwardWinner wants to merge 1 commit intotidyverse:masterfrom
DarwinAwardWinner wants to merge 1 commit intotidyverse:masterfrom
Conversation
Contributor
|
Some refactoring of the code base a while ago got rid of |
Contributor
Author
|
Would it be sufficient to add the following passage from other continuous scales (e.g. |
Contributor
|
That should do. |
Member
|
I'd much rather you passed along specific arguments so that the document for individual scales remains self contained. |
3f9e7e0 to
2d5683a
Compare
Merged
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to pass
na.valuetoscale_size_continuous, and was surprised when it threw an error instead of passing it along tocontinuous_scale. This pull request fixes that by having it pass along....