Skip to content

Scale gradient doc fix #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2016

Conversation

DarwinAwardWinner
Copy link
Contributor

The documentation now mentions "continuous_scale" instead of "discrete_scale".

Fixes #1736.

@hadley
Copy link
Member

hadley commented Sep 6, 2016

@thomasp85 can you please help @DarwinAwardWinner finish this off? I think it's tangled up with #1735

It now mentions "continuous_scale" instead of "discrete_scale".

Fixes tidyverse#1736.
@DarwinAwardWinner
Copy link
Contributor Author

I think I fixed it. I forgot to branch off from your master branch instead of mine.

@thomasp85
Copy link
Member

@hadley can I get some pointers to this? It seems your current preference is to remove ellipses where possible, but it is wildly inconsistent in the scales constructors.

Currently the following has all arguments spelled out:

  • scale_*_date
  • scale_*_datetime
  • scale_size_continuous
  • scale_radius

While the following uses ellipses:

  • scale_*_brewer
  • scale_*_distiller
  • scale_alpha_*
  • scale_size_discrete
  • scale_size_area
  • scale_shape
  • scale_*_manual
  • scale_linetype
  • scale_*_identity
  • scale_*_hue
  • scale_*_grey
  • scale_*_gradient

I can appreciate the wish to spell everything out in order for autocomplete to work etc, but I think we should port everything then, rather than fixing it here and there in related PR's such as this and #1735

@hadley
Copy link
Member

hadley commented Sep 15, 2016

Ok, then lets close this one and do all in one pass.

@hadley hadley closed this Sep 15, 2016
@hadley hadley reopened this Sep 15, 2016
@hadley
Copy link
Member

hadley commented Sep 15, 2016

Oh, but this doc fix is still good

@hadley hadley merged commit 9181611 into tidyverse:master Sep 15, 2016
@DarwinAwardWinner DarwinAwardWinner deleted the scale-gradient-doc-fix branch September 15, 2016 14:45
@lock
Copy link

lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants