LOOP-340 Integrate latest TidepoolKit into TidepoolService#5
Merged
darinkrauss merged 2 commits intodevfrom Apr 19, 2020
Merged
Conversation
Contributor
darinkrauss
commented
Apr 14, 2020
darinkrauss
commented
- https://tidepool.atlassian.net/browse/LOOP-340
- Add empty implementation of RemoteDataService
- Update Cartfile to latest LoopKit and TidepoolKit
- https://tidepool.atlassian.net/browse/LOOP-340 - Add empty implementation of RemoteDataService - Update Cartfile to latest LoopKit and TidepoolKit
rickpasetto
suggested changes
Apr 15, 2020
Contributor
rickpasetto
left a comment
rickpasetto
left a comment
There was a problem hiding this comment.
Carthage/Build files shouldn't be checked in, IMO. Folks should run carthage bootstrap on their own, and the whole Carthage subdirectory should be added to .gitignore.
Contributor
Author
|
@rickpasetto You brought up this same concern in an earlier PR. Please see #3 for our conversation. If you feel strongly that we should not be doing this for both |
Contributor
|
@darinkrauss ok. Can you wait until that discussion, or do you need to get this in sooner? |
Contributor
Author
|
@rickpasetto Removed cached Carthage build. |
ps2
approved these changes
Apr 17, 2020
darinkrauss
deleted the
darinkrauss/LOOP-340-integrate-latest-tidepoolkit
branch
ps2
added a commit
that referenced
this pull request
Apr 21, 2023
…-command-service Revert "Remote PR Set #2: Introduce RemoteCommands"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.